Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support latest did_you_mean #761

Merged

Conversation

deivid-rodriguez
Copy link
Contributor

Using DidYouMean::SPELL_CHECKERS.merge! has been deprecated.

Since this new version will be included with Ruby 3.1, I'm looking into supporting it without warnings.

@deivid-rodriguez
Copy link
Contributor Author

This breaks tests, so no good.

Using `DidYouMean::SPELL_CHECKERS.merge!` has been deprecated.
@deivid-rodriguez deivid-rodriguez force-pushed the support_latest_did_you_mean branch from 6bfceda to 98dbec7 Compare December 22, 2021 13:02
@deivid-rodriguez
Copy link
Contributor Author

Errors were caused by my stupidity, hopefully it's all good now :)

@yuki24
Copy link

yuki24 commented Dec 22, 2021

Thanks @deivid-rodriguez for wrapping this up. I happen to have sent the exact same PR as yours so I just closed mine. This change looks good to me from the did_you_mean side.

@deivid-rodriguez
Copy link
Contributor Author

No problem @yuki24!

@dorner
Copy link

dorner commented Dec 22, 2021

LGTM! @rafaelfranca ?

@emmahsax
Copy link

emmahsax commented Jan 3, 2022

@rafaelfranca Any updates on this? Would be super helpful to get this out so that all of our warning messages quiet up 😄 . Thank you!

@zchrb
Copy link

zchrb commented Jan 3, 2022

Echoing @emmahsax's comment. Wondering when this will be merged since all checks have passed 🤔

@ojab
Copy link

ojab commented Jan 3, 2022

Oh, c'mon it's holiday time and you're pinging ppl about deprecation warnings rails/rails#43998 (comment)

@emmahsax
Copy link

emmahsax commented Jan 3, 2022

@ojab I asked kindly. There are many times where I've felt bad for pinging people, but the truth is that pinging people to remind them or to place it higher in their notifications list is very different from expecting them to do something right away. People forget things all the time and need to be reminded, and that's okay.

I asked if there were any updates. A question that would accept an answer such as "I'm on vacation for the next week. I have plans to do it next Monday!". Which is very different from "Please do this today, because you can't possibly have anything better to do".

Lastly, the comment you linked to mentions the last two weeks of the year, and that time is now over. I don't feel like I am interrupting somebody's life because the person that I pinged is the same person that posted that comment you linked to four hours ago (AKA they were looking at their computer at some point today). I was polite, and asked them for updates, not to do it right away.

@ctilley83
Copy link

Oh, c'mon it's holiday time and you're pinging ppl about deprecation warnings rails/rails#43998 (comment)

Happy Holidays. For me it wasn't a warning and wouldn't allow me to start the dev server on rails 7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants