-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support latest did_you_mean #761
Support latest did_you_mean #761
Conversation
This breaks tests, so no good. |
Using `DidYouMean::SPELL_CHECKERS.merge!` has been deprecated.
6bfceda
to
98dbec7
Compare
Errors were caused by my stupidity, hopefully it's all good now :) |
Thanks @deivid-rodriguez for wrapping this up. I happen to have sent the exact same PR as yours so I just closed mine. This change looks good to me from the |
No problem @yuki24! |
LGTM! @rafaelfranca ? |
@rafaelfranca Any updates on this? Would be super helpful to get this out so that all of our warning messages quiet up 😄 . Thank you! |
Echoing @emmahsax's comment. Wondering when this will be merged since all checks have passed 🤔 |
Oh, c'mon it's holiday time and you're pinging ppl about deprecation warnings rails/rails#43998 (comment) |
@ojab I asked kindly. There are many times where I've felt bad for pinging people, but the truth is that pinging people to remind them or to place it higher in their notifications list is very different from expecting them to do something right away. People forget things all the time and need to be reminded, and that's okay. I asked if there were any updates. A question that would accept an answer such as "I'm on vacation for the next week. I have plans to do it next Monday!". Which is very different from "Please do this today, because you can't possibly have anything better to do". Lastly, the comment you linked to mentions the last two weeks of the year, and that time is now over. I don't feel like I am interrupting somebody's life because the person that I pinged is the same person that posted that comment you linked to four hours ago (AKA they were looking at their computer at some point today). I was polite, and asked them for updates, not to do it right away. |
Happy Holidays. For me it wasn't a warning and wouldn't allow me to start the dev server on rails 7.0 |
Using
DidYouMean::SPELL_CHECKERS.merge!
has been deprecated.Since this new version will be included with Ruby 3.1, I'm looking into supporting it without warnings.